Remove stuff that was deprecated for 2.5.0#1425
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
n2ygk commented May 22, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## master #1425 +/- ## ========================================== - Coverage 97.56% 97.42% -0.14% ========================================== Files 32 32 Lines 2132 2096 -36 ========================================== - Hits 2080 2042 -38 - Misses 52 54 +2 ☔ View full report in Codecov by Sentry. |
dopry reviewed May 22, 2024
Member
dopry left a comment
dopry left a comment There was a problem hiding this comment.
Looks good at a glance. I'll give it a more thorough review tomorrow.
dopry approved these changes Jun 10, 2024
Member
dopry commented Jun 10, 2024
Sorry work got the better for me for a hearbeat. LGTM. |
ContributorAuthor
n2ygk commented Jun 12, 2024
ugh codespell is messing us up. |
…ures until we can better tune it.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Removes deprecations that were warned would be removed in 2.5.0
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS