Handle invalid hex values in query strings in DRF extension#1444
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sarayourfriend commented Aug 12, 2024
@n2ygk any chance this PR can get a review? |
n2ygkforce-pushed the fix/invalid-hex-drf branch from ea18897 to aebb1deCompare
n2ygk requested changes Aug 12, 2024
Contributor
n2ygk left a comment
n2ygk left a comment There was a problem hiding this comment.
A minor wording to change to make clear what the fix is accomplishing plus a question about approach to determining the specific error.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Contributor
n2ygk commented Aug 12, 2024
BTW I had to rebase so make sure to do a pull. |
Contributor
n2ygk commented Aug 13, 2024
Looks like github is having an issue right now: |
n2ygk approved these changes Aug 13, 2024
Thanks @n2ygk and @AetherUnbound 🙏 |
ContributorAuthor
AetherUnbound commented Aug 13, 2024
Thank you! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#1443
Description of the Change
This PR applies a similar set of changes as #963 except for the Django Rest Framework contrib extension. I've tried my best to add tests for this case as well, but if there's anything else I'm missing please let me know!
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS