Skip to content

Conversation

@sahama
Copy link
Contributor

Fixes #

  • Using pk instead of id.

Description of the Change

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • [] documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk
Copy link
Contributor

Is this a repeat of #1445?

@sahama
Copy link
ContributorAuthor

Is this a repeat of #1445?

No. #1445 refer to custom primary key in user model and this is about custom primary key in django-oauth-toolkit models.

@n2ygk
Copy link
Contributor

Is this a repeat of #1445?

No. #1445 refer to custom primary key in user model and this is about custom primary key in django-oauth-toolkit models.

Ah, I see. Since these changes are closely related, can you please put the #1445 changes in here as well? Thanks.

@codecov
Copy link

codecovbot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.28%. Comparing base (102c851) to head (16cc0d8).

Additional details and impacted files
@@ Coverage Diff @@## master #1446 +/- ## ========================================== - Coverage 97.42% 97.28% -0.15%  ========================================== Files 32 32 Lines 2096 2096 ========================================== - Hits 2042 2039 -3 - Misses 54 57 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@n2ygkn2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Please take a look at the one question I have and resolve that.

@sahama
Copy link
ContributorAuthor

sahama commented Aug 3, 2024

Is this a repeat of #1445?

No. #1445 refer to custom primary key in user model and this is about custom primary key in django-oauth-toolkit models.

Ah, I see. Since these changes are closely related, can you please put the #1445 changes in here as well? Thanks.

ok. I get new branch from that. so change are here too.

@n2ygkn2ygk added this to the 3.0.0 milestone Aug 15, 2024
@n2ygkn2ygk merged commit 146e8bf into masterAug 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sahama@n2ygk