Provide django.contrib.auth.authenticate() with a request for compatibiity with more backends. #949
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@## master #949 +/- ## ========================================== + Coverage 96.59% 96.60% +0.01% ========================================== Files 31 31 Lines 1704 1710 +6 ========================================== + Hits 1646 1652 +6 Misses 58 58
Continue to review full report at Codecov.
|
ShaheedHaqueforce-pushed the enhance_compatibility_with_django_auth branch from f179f76 to a0ead0bComparecompatibiity with more backends. Resolvesdjango-oauth#712. Resolvesdjango-oauth#636. Resolvesdjango-oauth#808.
ShaheedHaqueforce-pushed the enhance_compatibility_with_django_auth branch from 7506170 to 2989685Compare
Contributor
n2ygk commented Mar 22, 2021
@ShaheedHaque are you ready for review? I seem to have jumped the gun and started reviewing.... |
ContributorAuthor
ShaheedHaque commented Mar 22, 2021
@n2ygk Yes, sorry, I kept seeing merge conflicts and the like because I caught things just as 1.5.0 was going out. Also, there was a slight reduction in code coverage which I realised I could eliminate. No more changes are planned at this point :-). |
Clean up some mis-merged updates.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#712
Fixes#636
Fixes#808
Description of the Change
The function django.contrib.auth.authenticate() has an optional first
requestargument. Some backends, such as django-axes (i.e. the subject of #712) and others (i.e. the subject of #636) require this argument to be present. This change provides this argument.Additionally, this change is based on the patch in #712, and constructs a Django HttpRequest object from the DOT request object in order to provide API compatibility. This avoid the issue that caused the original fix for #636 to be reverted, and also addresses #808.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS