Remove s390x from Alpine variants on 3.14(+)#1015
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
I've also refactored all our "exclude an architecture in certain combinations" sections to have slightly more context in-file and to be more targeted/focused on a single issue so they're easier to read. ```diff $ diff -u <(bashbrew cat python) <(bashbrew cat <(./generate-stackbrew-library.sh)) --- /dev/fd/63 2025-04-01 15:12:40.298947543 -0700 +++ /dev/fd/62 2025-04-01 15:12:40.298947543 -0700 @@ -24,12 +24,12 @@ Directory: 3.14-rc/slim-bullseye Tags: 3.14.0a6-alpine3.21, 3.14-rc-alpine3.21, 3.14.0a6-alpine, 3.14-rc-alpine -Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x +Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le GitCommit: 0bd9769 Directory: 3.14-rc/alpine3.21 Tags: 3.14.0a6-alpine3.20, 3.14-rc-alpine3.20 -Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le, s390x +Architectures: amd64, arm32v6, arm32v7, arm64v8, i386, ppc64le GitCommit: 0bd9769 Directory: 3.14-rc/alpine3.20 ```
tianon commented Apr 1, 2025
Comment on lines -151 to -154
| if [ "$fullVersion"='3.14.0a1' ];then | ||
| # https://github.com/python/cpython/issues/125535 - 3.14.0a1 fails to build on i386 | ||
| # https://github.com/python/cpython/pull/125244 (already fixed for the next release) | ||
| variantArches="$(sed <<<" $variantArches " -e 's/ i386 / /g')" |
MemberAuthor
There was a problem hiding this comment.
This is also straight up dead code. 😄
yosifkit approved these changes Apr 1, 2025
yosifkit merged commit dca0bac into docker-library:master 47 checks passed
Uh oh!
There was an error while loading. Please reload this page.
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 1, 2025
Changes: - docker-library/python@dca0bace: Merge pull request docker-library/python#1015 from infosiftr/rm-3.14-s390x-alpine - docker-library/python@46594edb: Remove s390x from Alpine variants on 3.14(+)
gquintard pushed a commit to gquintard/official-images that referenced this pull request Jun 11, 2025
Changes: - docker-library/python@dca0bace: Merge pull request docker-library/python#1015 from infosiftr/rm-3.14-s390x-alpine - docker-library/python@46594edb: Remove s390x from Alpine variants on 3.14(+)
tglman pushed a commit to tglman/official-images that referenced this pull request Aug 11, 2025
Changes: - docker-library/python@dca0bace: Merge pull request docker-library/python#1015 from infosiftr/rm-3.14-s390x-alpine - docker-library/python@46594edb: Remove s390x from Alpine variants on 3.14(+)
gquintard pushed a commit to gquintard/official-images that referenced this pull request Aug 15, 2025
Changes: - docker-library/python@dca0bace: Merge pull request docker-library/python#1015 from infosiftr/rm-3.14-s390x-alpine - docker-library/python@46594edb: Remove s390x from Alpine variants on 3.14(+)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've also refactored all our "exclude an architecture in certain combinations" sections to have slightly more context in-file and to be more targeted/focused on a single issue so they're easier to read.
Closes#1014