Skip to content

Conversation

@orgads
Copy link

Reduces slim-bookworm image from 180M to 155M.

@sdwolfz
Copy link
Contributor

This might be something you would do for the slim variants, but please don't do this for every image. Alpine is already slim enough.

@orgadsorgads changed the title Strip all binariesStrip all binaries for slim imagesSep 6, 2024
@orgads
Copy link
Author

This might be something you would do for the slim variants, but please don't do this for every image. Alpine is already slim enough.

Sure, done.

@orgads
Copy link
Author

Though the size reduction for alpine is even better in percentage: 90M -> 67M. Is there a reason not to strip?

@orgads
Copy link
Author

@sdwolfz 👆🏻

@sdwolfz
Copy link
Contributor

Sorry but you should await feedback from @tianon here. My point is, slim images are designed to be small, but the non slim ones, if a linux binary is expected on the live system, then people will also expect it in the docker image, so this might break people's expectations.

@orgads
Copy link
Author

  1. alpine is slim by design
  2. What do you mean by expecting a linux binary? I didn't delete anything here, only stripped debugging symbols. All package managers do this.

@LaurentGoderre
Copy link
Member

This might be a breaking change so it might be bettter to do for a new version.

@orgads
Copy link
Author

What do you mean by a new version? Aren't the docker images tagged separately?

@tianon
Copy link
Member

The difference with package managers is that they typically provide something like dbgsym packages that can reinclude the debugging symbols external to the binaries, which is very difficult for us to provide effectively, as seen/discussed in docker-library/php#1538 (and linked issues), so I'm hesitant to opine on whether this is generally reasonable for us to do.

@orgads
Copy link
Author

You can create another image variant with -debug.

Have you ever used the debugging symbols in the image?

Reduces slim-bookworm image from 180M to 155M.
@orgads
Copy link
Author

Rebased. Ping?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@orgads@sdwolfz@LaurentGoderre@tianon