Insert function for arrays#199
Uh oh!
There was an error while loading. Please reload this page.
Conversation
Throw TypeError if insert receives something other than an array
jgonggrijp added before modules 
jgonggrijp left a comment
jgonggrijp left a comment There was a problem hiding this comment.
Thank you @acarrau for your submission and sorry for the late reply. I think this is a useful function to have. I would remove the tight restriction on the first argument having to be a proper array, but otherwise I think the implementation and the tests are sound. Documentation still needs to be added.
Would you like to finish the PR yourself? Otherwise, I or somebody else can take it from here. You will get the credits for the work you already did in any case.
| // Inserts an item in an array at the specific index mutating the original | ||
| // array and returning it. | ||
| insert: function(array,index,item){ | ||
| if(!_.isArray(array))thrownewTypeError('Expected an array as the first argument'); |
There was a problem hiding this comment.
I think this check is too restrictive, because splice also works with arguments and similar array-like objects. I think you can just remove this line.
2 participants
I thought an 'insert item at' function for arrays would be nice to have, avoiding the use of splice where 0 needs to be passed as the 2nd 'deleteCount' parameter.
It works the same way the _.extend function does, where the first parameter gets modified and the result is also returned.