Skip to content

[ML UI/AI Infra][9.3 & Serverless]: Anomaly Detection: Alerting rule filtering #4240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nastasha-solomon wants to merge 14 commits into
base:main
Choose a base branch
from
Open

[ML UI/AI Infra][9.3 & Serverless]: Anomaly Detection: Alerting rule filtering #4240

nastasha-solomon wants to merge 14 commits into from
+37 −20

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomonnastasha-solomon commented Dec 8, 2025•
edited
Loading

Summary

Fixes#4145. By explaining how to use the new Anomaly filter field to narrow down the list of anomalies that ML anomaly detection rules check for. Also refreshes outdated screenshots.

Generative AI disclosure

  1. Did you use a generative AI (GenAI) tool to assist in creating this contribution?
  • Yes
  • No

Preview

@nastasha-solomonnastasha-solomon self-assigned this Dec 8, 2025
@github-actions
Copy link

github-actionsbot commented Dec 8, 2025•
edited
Loading

✅ Vale Linting Results

No issues found on modified lines!

@github-actions
Copy link

github-actionsbot commented Dec 8, 2025•
edited
Loading

🔍 Preview links for changed docs

@nastasha-solomonnastasha-solomon marked this pull request as ready for review December 8, 2025 19:06
@nastasha-solomonnastasha-solomon requested review from a team as code ownersDecember 8, 2025 19:06
benironside
benironside reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

@benironsidebenironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Left a few suggestions for your consideration, I'm not an expert on this so take it with a grain of salt. If you decide to apply them to ml-configuring-alerts.md, you may want to also update create-an-anomaly-detection-rule.md

bmorelli25
bmorelli25 reviewed Dec 8, 2025
View reviewed changes
Copy link
Member

@bmorelli25bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some feedback on screenshots that you didn't ask for 😬 sorry!

explore-analyze/machine-learning/anomaly-detection/ml-configuring-alerts.md Outdated
:::{image} /explore-analyze/images/ml-anomaly-create-anomaly-detection.png
:alt: Selecting Anomaly detection rule type
:screenshot:
:::
Copy link
Member

@bmorelli25bmorelli25Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you didn't add this (maybe you did previously?). I'm not sure this screenshot adds any value. The instruction for this line is short and to the point 2. Select the **{{anomaly-detect-cap}}** rule type.. What do you think about removing this screenshot?

Copy link
ContributorAuthor

@nastasha-solomonnastasha-solomonDec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with removing. I was thinking the same : )

@nastasha-solomon@benironside
Update explore-analyze/machine-learning/anomaly-detection/ml-configur…
78b6411
…ing-alerts.md Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
nastasha-solomonand others added 2 commits December 10, 2025 11:17
@nastasha-solomon@benironside
Update explore-analyze/machine-learning/anomaly-detection/ml-configur…
2563dbc
…ing-alerts.md Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
@nastasha-solomon@benironside
Update explore-analyze/machine-learning/anomaly-detection/ml-configur…
24ce002
…ing-alerts.md Co-authored-by: Benjamin Ironside Goldstein <[email protected]>
rbrtj
rbrtj approved these changes Dec 12, 2025
View reviewed changes
Copy link

@rbrtjrbrtj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM 👍

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmorelli25bmorelli25bmorelli25 left review comments

@benironsidebenironsidebenironside left review comments

@rbrtjrbrtjrbrtj approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@nastasha-solomonnastasha-solomon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Internal][ML UI/AI Infra][Alerting]: Anomaly Detection: Alerting rule filtering

5 participants

@nastasha-solomon@bmorelli25@benironside@rbrtj