Production routing table config uses config_env (#1)#1536
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`Mix.env()` is not available in runtime.exs, and it's not clear from the text where the production routing table should go. This clarifies that it should be in `runtime.exs` and demonstrates the use of `config_env()` (instead of `Mix.env()`)
Uh oh!
There was an error while loading. Please reload this page.
Member
josevalim commented Jun 20, 2021
💚 💙 💜 💛 ❤️ |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mix.env()is not available in runtime.exs, and it's not clear from the text where the production routing table should go. This clarifies that it should be inruntime.exsand demonstrates the use ofconfig_env()(instead ofMix.env())Fixes#1535.
I'm not sure if overwriting the config is idiomatic, or if the default single entry routing table should be in a non-prod check?