Modify over-indentation for PEAR style#777
Merged
+27 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
zonuexe commented Dec 17, 2023
| functionmy_func(){ | ||
| return"a really long string with = inside " . | ||
| "some more text"; // ###php-mode-test### ((indent 49)) | ||
| "some more text"; // ###php-mode-test### ((indent 8)) |
MemberAuthor
There was a problem hiding this comment.
Previously, this line was indented by PEAR style as shown below.
function my_func(){return "a really long string with = inside " . - "some more text"; // ###php-mode-test### ((indent 49))+ "some more text"; // ###php-mode-test### ((indent 8)) }
This was referenced Dec 17, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer overindent it by default, since we don't see any mention in the coding style that it should hang
..closes#227, #774 and #745, refs #229.
Note
If you have any feedback on PEAR style, please let us know in the discussion #776.