Apply typescript-eslint's recommended config to gts files#120
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
"Patch" `typescript-eslint`'s recommended config to allow us to extend it to `gts` files, and also add test cases to verify that we're applying the ruleset to both `ts` and `gts` files. Fixesember-cli#119
bendemboski added a commit to bendemboski/ember-app-blueprint that referenced this pull request Nov 24, 2025
"Patch" `typescript-eslint`'s recommended config to allow us to extend it to `gts` files, and also add test cases to verify that we're applying the ruleset to both `ts` and `gts` files. This is the equivalent of ember-cli/ember-addon-blueprint#120 for this repo
| // https://github.com/ember-cli/ember-addon-blueprint/issues/119 | ||
| { | ||
| ...ts.configs.eslintRecommended, | ||
| files: undefined, |
Contributor
There was a problem hiding this comment.
looks like this hack isn't needed?
bendemboski added a commit to bendemboski/ember-app-blueprint that referenced this pull request Nov 26, 2025
"Patch" `typescript-eslint`'s recommended config to allow us to extend it to `gts` files, and also add test cases to verify that we're applying the ruleset to both `ts` and `gts` files. This is the equivalent of ember-cli/ember-addon-blueprint#120 for this repo
NullVoxPopuli approved these changes Dec 6, 2025
NullVoxPopuli merged commit fe5d8e3 into ember-cli:main 13 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Patch"
typescript-eslint's recommended config to allow us to extend it togtsfiles, and also add test cases to verify that we're applying the ruleset to bothtsandgtsfiles.Fixes#119