Add build mode tests (ensuring isDevelopingApp and isTesting are appropriately true when they need to be (as well as assert-stripping))#66
+132 −54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading. Please reload this page.
| "c8": "^7.11.3", | ||
| "ember-cli": "github:ember-cli/ember-cli#master", | ||
| "execa": "^9.5.2", | ||
| "execa": "^9.6.0", |
ContributorAuthor
There was a problem hiding this comment.
could be PR'd separately
| addonDir=join(tmpDir,addonName); | ||
| awaitexeca({ | ||
| cwd: tmpDir, | ||
| extendEnv: false, |
ContributorAuthor
There was a problem hiding this comment.
extendEnv is noise in this PR without an accompanying env:{} to set the env to empty
Contributor
mkszepp commented Dec 23, 2025
Would be nice to get this PR In ember-basic-dropdown i have |
NullVoxPopuliforce-pushed the nvp/add-build-mode-tests branch from 8a895fd to da5827fCompareNullVoxPopuli changed the title Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
followup to: #64
Key changes:
@glimmer/envforDEBUGsupport (only for the dev/test babel.config)@embroider/macros/src/vendor/embroider-macros-test-support