Respect timeout with SSL#8899
Respect timeout with SSL #8899
Uh oh!
There was an error while loading. Please reload this page.
Conversation
| intconnect(IPAddress ip, uint16_t port) override{uto(); return _ctx->connect(ip, port)} | ||
| intconnect(const String& host, uint16_t port) override{uto(); return _ctx->connect(host, port)} | ||
| intconnect(constchar* name, uint16_t port) override{uto(); return _ctx->connect(name, port)} | ||
| uint8_tconnected() override{uto(); return _ctx->connected()} | ||
| size_twrite(constuint8_t *buf, size_t size) override{uto(); return _ctx->write(buf, size)} | ||
| size_twrite_P(PGM_P buf, size_t size) override{uto(); return _ctx->write_P(buf, size)} | ||
| size_twrite(constchar *buf){uto(); returnwrite((constuint8_t*)buf, strlen(buf))} | ||
| size_twrite_P(constchar *buf){uto(); returnwrite_P((PGM_P)buf, strlen_P(buf))} | ||
| size_twrite(Stream& stream) /* Note this is not virtual */{uto(); return _ctx->write(stream)} | ||
| intread(uint8_t *buf, size_t size) override{uto(); return _ctx->read(buf, size)} | ||
| intavailable() override{uto(); return _ctx->available()} | ||
| intavailableForWrite() override{uto(); return _ctx->availableForWrite()} | ||
| intread() override{uto(); return _ctx->read()} | ||
| intpeek() override{uto(); return _ctx->peek()} | ||
| size_tpeekBytes(uint8_t *buffer, size_t length) override{uto(); return _ctx->peekBytes(buffer, length)} | ||
| boolflush(unsignedint maxWaitMs){uto(); return _ctx->flush(maxWaitMs)} | ||
| boolstop(unsignedint maxWaitMs){uto(); return _ctx->stop(maxWaitMs)} |
There was a problem hiding this comment.
d-a-v/Arduino@ssltimeout...mcspr:esp8266-Arduino:ssltimeout ?
reiterating on the matrix discussion - no need to touch _timeout when not necessary, ctx class can have its own timeout state
implementing method override should fix the after-connect setting of timeout as well
There was a problem hiding this comment.
_ctx is not accessible from user side.sslclient.setTimeout() can be called from the Stream class (Stream& s = sslclient; s.setTimeout(1234);)Stream::setTimeout is not virtual and I'm not sure that modifying Arduino API is not going to be a breaking change but you tell me.Stream::_timeout updates from client side are ignored until forwarded to the context _ctx.
Considering that user can update this timeout anytime, I placed these many calls where _timeout is used.
edit This commit reverts this one where there was an unwanted pointer of the client stream inside the context to help reaching user timeout.
edit2 now Stream::setTimeout() is virtual
Uh oh!
There was an error while loading. Please reload this page.
2 participants
Uh oh!
There was an error while loading. Please reload this page.