Skip to content

bugfix(uart + i2c): fix signal glitch on tx , i2c sda and i2c scl pin#1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ESP32DE wants to merge 3 commits into from
Closed

bugfix(uart + i2c): fix signal glitch on tx , i2c sda and i2c scl pin #1065

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90b3413
bugfix(uart): fix signal glitch on tx pin
ESP32DE Feb 2, 2018
d700b5a
bugfix(i2c): fix signal glitch on sda and scl pin -optional for actua…
ESP32DE Feb 4, 2018
283ca32
Update esp32-hal-i2c.c
ESP32DE Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions cores/esp32/esp32-hal-i2c.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,10 @@ i2c_err_t i2cAttachSCL(i2c_t * i2c, int8_t scl)
if(i2c == NULL){
return I2C_ERROR_DEV;
}
pinMode(scl, OUTPUT_OPEN_DRAIN | PULLUP);
digitalWrite(scl, HIGH); // optional, tested successful in actually version
// pinMode(scl, OUTPUT_OPEN_DRAIN | PULLUP);
pinMode(scl, OPEN_DRAIN | PULLUP); // open for a test on weekend
// digitalWrite(scl, HIGH); // successful tested in a prev version, but fails in the actually so use optional!
pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);
pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);
return I2C_ERROR_OK;
Expand All@@ -94,7 +97,10 @@ i2c_err_t i2cAttachSDA(i2c_t * i2c, int8_t sda)
if(i2c == NULL){
return I2C_ERROR_DEV;
}
pinMode(sda, OUTPUT_OPEN_DRAIN | PULLUP);
digitalWrite(sda, HIGH); // optional, tested successful in actually version
// pinMode(sda, OUTPUT_OPEN_DRAIN | PULLUP);
pinMode(sda, OPEN_DRAIN | PULLUP); // open for a test on weekend
// digitalWrite(sda, HIGH); // successful tested in a prev version, but fails in the actually so use optional!
pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);
pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);
return I2C_ERROR_OK;
Expand Down
1 change: 1 addition & 0 deletions cores/esp32/esp32-hal-uart.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -154,6 +154,7 @@ void uartAttachTx(uart_t* uart, uint8_t txPin, bool inverted)
return;
}
pinMode(txPin, OUTPUT);
digitalWrite(txPin, HIGH);
pinMatrixOutAttach(txPin, UART_TXD_IDX(uart->num), inverted, false);
}

Expand Down