Skip to content

bugfix(i2c): fix signal glitch on sda and scl pin#1073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ESP32DE wants to merge 1 commit into from
Closed

bugfix(i2c): fix signal glitch on sda and scl pin #1073

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cores/esp32/esp32-hal-i2c.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,9 @@ i2c_err_t i2cAttachSCL(i2c_t * i2c, int8_t scl)
if(i2c == NULL){
return I2C_ERROR_DEV;
}
// digitalWrite(scl, HIGH); // optional before
pinMode(scl, OUTPUT_OPEN_DRAIN | PULLUP);
digitalWrite(scl, HIGH); // tested
pinMatrixOutAttach(scl, I2C_SCL_IDX(i2c->num), false, false);
pinMatrixInAttach(scl, I2C_SCL_IDX(i2c->num), false);
return I2C_ERROR_OK;
Expand All@@ -94,7 +96,9 @@ i2c_err_t i2cAttachSDA(i2c_t * i2c, int8_t sda)
if(i2c == NULL){
return I2C_ERROR_DEV;
}
// digitalWrite(sda, HIGH); // optional before
pinMode(sda, OUTPUT_OPEN_DRAIN | PULLUP);
digitalWrite(sda, HIGH); // tested
pinMatrixOutAttach(sda, I2C_SDA_IDX(i2c->num), false, false);
pinMatrixInAttach(sda, I2C_SDA_IDX(i2c->num), false);
return I2C_ERROR_OK;
Expand Down