fix: BLEAdvertising methods return error codes

[FidelSch]

Some methods on BLEAdvertising returned void even if they could produce an error, in which case they failed silently. They now return the corresponding error code.

Description of Change

These methods have been modified to return any potential error code

Tests scenarios

Unfortunately I currently do not have the necessary HW available

Related links

Addresses #6003

[CLAassistant]

All committers have signed the CLA.

[github-actions]

	Warnings
⚠️	Some issues found for the commit messages in this PR: the commit message "fix: BLEAdvertising methods return error codes": body's lines must not be longer than 100 characters Please fix these commit messages - here are some basic tips: follow Conventional Commits style correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter avoid Jira references in commit messages (unavailable/irrelevant for our customers) TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️	The source branch "BLEAdvertising-return-codes" incorrect format: contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS). Please rename your branch.

👋 Hello FidelSch, we appreciate your contribution to this project!

---

📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

---

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

---

Click to see more instructions ...

This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...

We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against ae1d904

[SuGlider]

@FidelSch - Arduino returns bool to indicate an operation success or failure.
esp_err_t is used under IDF. A possible way to chage it would by testing esp_err_t ESP_OK in the return of an IDF functions.

Could you change the code to test ESP_OK returning true or false instead?
All functions would return bool.

[FidelSch]

Thanks for your suggestions. I should mention I now used "yoda notation" for the evaluation of the return value, as this is how it is implemented in other methods in the same file. I was not sure wether to modify the if statements with similar expressions, so I didn't. If you think this would be a good idea, I am happy to implement it.

[github-actions]

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

Memory	FLASH [bytes]		FLASH [%]		RAM [bytes]		RAM [%]
Target	DEC	INC	DEC	INC	DEC	INC	DEC	INC
ESP32S3	0	⚠️ +32	0.00	0.00	0	0	0.00	0.00
ESP32C3	💚 -50	0	💚 -0.01	0.00	0	0	0.00	0.00
ESP32C6	💚 -50	0	0.00	0.00	0	0	0.00	0.00
ESP32H2	💚 -50	0	0.00	0.00	0	0	0.00	0.00
ESP32	0	⚠️ +40	0.00	0.00	0	0	0.00	0.00

Click to expand the detailed deltas report [usage change in BYTES]

Target	ESP32S3		ESP32C3		ESP32C6		ESP32H2		ESP32
Example	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM	FLASH	RAM
libraries/BLE/examples/BLE5_extended_scan	0	0	0	0	0	0	0	0	-	-
libraries/BLE/examples/BLE5_multi_advertising	0	0	0	0	0	0	0	0	-	-
libraries/BLE/examples/BLE5_periodic_advertising	0	0	0	0	0	0	0	0	-	-
libraries/BLE/examples/BLE5_periodic_sync	0	0	0	0	0	0	0	0	-	-
libraries/BLE/examples/Beacon_Scanner	0	0	0	0	0	0	0	0	0	0
libraries/BLE/examples/Client	0	0	0	0	0	0	0	0	0	0
libraries/BLE/examples/EddystoneTLM_Beacon	⚠️ +32	0	💚 -16	0	💚 -16	0	💚 -16	0	⚠️ +28	0
libraries/BLE/examples/EddystoneURL_Beacon	⚠️ +32	0	💚 -16	0	💚 -16	0	💚 -16	0	⚠️ +40	0
libraries/BLE/examples/Notify	0	0	💚 -50	0	💚 -50	0	💚 -50	0	0	0
libraries/BLE/examples/Scan	0	0	0	0	0	0	0	0	0	0
libraries/BLE/examples/Server	0	0	💚 -50	0	💚 -50	0	💚 -50	0	⚠️ +4	0
libraries/BLE/examples/Server_multiconnect	0	0	💚 -50	0	💚 -50	0	💚 -50	0	⚠️ +4	0
libraries/BLE/examples/UART	0	0	💚 -50	0	💚 -50	0	💚 -50	0	⚠️ +4	0
libraries/BLE/examples/Write	0	0	💚 -50	0	💚 -50	0	💚 -50	0	⚠️ +4	0
libraries/BLE/examples/iBeacon	⚠️ +24	0	💚 -22	0	💚 -22	0	💚 -22	0	⚠️ +20	0

[SuGlider]

bool BLEAdvertising::start() must return a value. all good.

[github-actions]

Test Results

76 files 76 suites 12m 48s ⏱️
38 tests 38 ✅ 0 💤 0 ❌
241 runs 241 ✅ 0 💤 0 ❌

Results for commit ae1d904.

♻️ This comment has been updated with latest results.

[SuGlider]

All fine. Thanks!