- Notifications
You must be signed in to change notification settings - Fork 7.8k
refactor(ble): minor BLE library cleanup#11789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
github-actionsbot commented Sep 3, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
👋 Hello Kolcha, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
github-actionsbot commented Sep 3, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Test Results 76 files 76 suites 14m 28s ⏱️ Results for commit 3c31d67. ♻️ This comment has been updated with latest results. |
github-actionsbot commented Sep 3, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
| |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
lucasssvaz commented Sep 4, 2025
Could you rebase your PR with the latest BLE changes ? |
- made many getters `const` (as it supposed to be) - pass string by reference in modified classes - other random code cleanup / fixes
Kolcha commented Sep 8, 2025
rebased |
SuGlider left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Kolcha for the contribution!
a39d1bd into espressif:masterUh oh!
There was an error while loading. Please reload this page.
Checklist
This entire section above can be deleted if all items are checked.
Description of Change
minor BLE library cleanup:
const(as it supposed to be)Test Scenarios
I have tested my Pull Request on Arduino-esp32 core v3.3.0 with ESP32. Successful build is enough to confirm that everything is ok.
Related links
nothing