HardwareSerial - add changeBaudRate method#2223
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cores/esp32/HardwareSerial.h Outdated
| voidbegin(unsignedlong baud, uint32_t config=SERIAL_8N1, int8_t rxPin=-1, int8_t txPin=-1, bool invert=false, unsignedlong timeout_ms = 20000UL); | ||
| voidend(); | ||
| voidupdateBaudRate(unsignedlong baud); |
Member
me-no-dev commented Dec 23, 2018
One comment on style :) please fix and I will merge. I have an idea for the bad char. |
ContributorAuthor
toomasz commented Dec 23, 2018
@me-no-dev done |
Member
me-no-dev commented Dec 23, 2018
Thanks :) |
ContributorAuthor
toomasz commented Dec 23, 2018
No problem, could you close #441 also? |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
#441