Wait for client.available() to prevent ESP32 crashes#3154
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| // We start by connecting to a WiFi network | ||
| WiFiMulti.addAP("SSID", "passpasspass"); | ||
| // WiFiMulti.addAP("SSID", "passpasspass"); | ||
| WiFiMulti.addAP("ARRIS-6089", "LaserJet4"); |
Member
There was a problem hiding this comment.
Do you really want this change here?
| // const uint16_t port = 80; | ||
| // const char * host = "192.168.1.1" // ip or dns | ||
| constuint16_t port = 1337; | ||
| constchar * host = "192.168.1.10"; // ip or dns |
| if (client.available() > 0) | ||
| { | ||
| //read back one line from the server | ||
| String line = client.readStringUntil('\r'); |
Member
There was a problem hiding this comment.
so the issue is that readStringUntil timeouts
ContributorAuthor
paynterf commented Sep 5, 2019 via email
oops - my bad. Although, it is extremely unlikely that someone else will be able to connect to my wireless network (we live in an underground house) ;-) Frank …On Thu, Sep 5, 2019 at 3:29 AM Me No Dev ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In libraries/WiFi/examples/WiFiClientBasic/WiFiClientBasic.ino <#3154 (comment)> : > @@ -14,7 +14,8 @@ void setup() delay(10); // We start by connecting to a WiFi network - WiFiMulti.addAP("SSID", "passpasspass"); +// WiFiMulti.addAP("SSID", "passpasspass"); + WiFiMulti.addAP("ARRIS-6089", "LaserJet4"); Do you really want this change here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3154?email_source=notifications&email_token=AA6T325NIMBPJ22DEFMRRRDQICYPNA5CNFSM4IR3BFVKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDXHYUA#pullrequestreview-284064848>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6T32YKYMTI23NS7CXHUMDQICYPNANCNFSM4IR3BFVA> . -- G.Frank Paynter, PhD OSU ESL Research Scientist (ret) EM Workbench LLC 614 638-6749 (cell) |
Contributor
stickbreaker commented Sep 5, 2019
Yea, but someone would complain when it didn't automagically connect to their WiFi. |
ContributorAuthor
paynterf commented Sep 6, 2019 via email
Chuck, LOL ;-) Frank …On Thu, Sep 5, 2019 at 1:36 PM chuck todd ***@***.***> wrote: oops - my bad. Although, it is extremely unlikely that someone else will be able to connect to my wireless network (we live in an underground house) ;-) Frank Yea, but someone would complain when it didn't automagically connect to their WiFi. Chuck. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#3154?email_source=notifications&email_token=AA6T32ZBBO4OVATEJJZJTODQIE7QPA5CNFSM4IR3BFVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AB7LI#issuecomment-528490413>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA6T322L3WZN6QKWX5HLIS3QIE7QPANCNFSM4IR3BFVA> . -- G.Frank Paynter, PhD OSU ESL Research Scientist (ret) EM Workbench LLC 614 638-6749 (cell) |
ContributorAuthor
paynterf commented Sep 6, 2019
Removed user-specific SSID/passphrase |
HendrikVE pushed a commit to HendrikVE/arduino-esp32 that referenced this pull request Nov 24, 2020
* Wait for client.available() to prevent ESP32 crashes * Removed user-specific SSID & passphrase
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that the original code consistently crashed my ESP32 Dev Board with a 'Guru Meditation Error'. When I looked into the code, I saw that it tried to read a string from the server before anything was available, causing the crash. By guarding the read statement with a 'while' loop that waited for client.available() to return a non-zero result (or for the max loop counter to expire), I was able to get reliable performance.