Skip to content

Conversation

@VojtechBartoska
Copy link
Contributor

Summary

This Pull request contains changes of 3 files:

1) Slightly updating of Issue report template

  • adding more options in Arduino ESP32 core list to solve issue with wrongly used "latest master" version
  • Sketch description update to increase quality of provided sketch

2) Pull Request Templates update

  • added check box for Relevant Documentation update
  • Main parts updated and added part for Test scenarios

3) Readme page update

  • mentioned Github repository Discussions
  • fixed table of content
  • Roadmap, Sprint Meeting notes and Community Meetings links added

Impact

Purpose of this Pull Request is to:

  • improve User experience
  • collect more specific information which can help with solving Issue reports and Pull requests
  • Make our internal planning more visible and increase Community engagement

Related links

Close this ticket

@github-actions
Copy link
Contributor

github-actionsbot commented Apr 13, 2022

Unit Test Results

0 files 0 suites 0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 0c3886d.

♻️ This comment has been updated with latest results.

@VojtechBartoskaVojtechBartoska added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Apr 13, 2022
@VojtechBartoskaVojtechBartoska self-assigned this Apr 13, 2022
@VojtechBartoskaVojtechBartoska removed the request for review from igrrApril 13, 2022 14:31
Copy link
Member

@pedrominatelpedrominatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small changes, otherwise LTGM!

@me-no-devme-no-dev merged commit b3c203d into espressif:masterApr 21, 2022
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Apr 21, 2022
* Delete stale.yml * IDF release/v4.4 b8050b365e (espressif#6594) * Update camera example to support face detection and recognition (espressif#6603) Fixes: espressif#6508 * Change pinMode OUTPUT to INPUT_OUTPUT (espressif#6602) * Change OUTPUT to INPUT_OUTPUT To match the official Arduino API. * Changed type of LEDC frequency from double to uint32_t (espressif#6570) * BUGFIX: FS read + speed improvements for SD (espressif#6569) * Revert "Edited VFSFileImpl::read to use both read/fread (espressif#6456)" This reverts commit 7b89b39. * Added default file buffer size + function to change it by user * workflows/publish.yml: Run the workflow on success and failure only. (espressif#6531) * workflows/publish.yml: Run the workflow on success and failure only. This prevents trying to run when the trigger was cancelled or skipped. In these cases there will be no event file to upload. Signed-off-by: Abdelatif Guettouche <[email protected]> * scripts/sketch_utils.sh: Move the logic that gets the build dir after the part that retrieves the arguments. Signed-off-by: Abdelatif Guettouche <[email protected]> * workflows/hil.yml: Update the HIL runners tags. Signed-off-by: Abdelatif Guettouche <[email protected]> * workflows/hil.yml: Remove the Check Artifacts step. That was only useful for debugging. Signed-off-by: Abdelatif Guettouche <[email protected]> * Pull request/Issue Templates and Readme update (espressif#6577) * Templates and readme * Templates_and_readme * Delete libraries/RainMaker directory * Delete tools/sdk/esp32/include/esp_rainmaker directory * Delete tools/sdk/esp32s2/include/esp_rainmaker directory * Delete tools/sdk/esp32s3/include/esp_rainmaker directory * Delete tools/sdk/esp32c3/include/esp_rainmaker directory Co-authored-by: Me No Dev <[email protected]> Co-authored-by: Jan Procházka <[email protected]> Co-authored-by: Abdelatif Guettouche <[email protected]> Co-authored-by: Vojtěch Bartoška <[email protected]>
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Apr 24, 2022
* Delete stale.yml * IDF release/v4.4 b8050b365e (espressif#6594) * Update camera example to support face detection and recognition (espressif#6603) Fixes: espressif#6508 * Change pinMode OUTPUT to INPUT_OUTPUT (espressif#6602) * Change OUTPUT to INPUT_OUTPUT To match the official Arduino API. * Changed type of LEDC frequency from double to uint32_t (espressif#6570) * BUGFIX: FS read + speed improvements for SD (espressif#6569) * Revert "Edited VFSFileImpl::read to use both read/fread (espressif#6456)" This reverts commit 7b89b39. * Added default file buffer size + function to change it by user * workflows/publish.yml: Run the workflow on success and failure only. (espressif#6531) * workflows/publish.yml: Run the workflow on success and failure only. This prevents trying to run when the trigger was cancelled or skipped. In these cases there will be no event file to upload. Signed-off-by: Abdelatif Guettouche <[email protected]> * scripts/sketch_utils.sh: Move the logic that gets the build dir after the part that retrieves the arguments. Signed-off-by: Abdelatif Guettouche <[email protected]> * workflows/hil.yml: Update the HIL runners tags. Signed-off-by: Abdelatif Guettouche <[email protected]> * workflows/hil.yml: Remove the Check Artifacts step. That was only useful for debugging. Signed-off-by: Abdelatif Guettouche <[email protected]> * Pull request/Issue Templates and Readme update (espressif#6577) Co-authored-by: Me No Dev <[email protected]> Co-authored-by: Jan Procházka <[email protected]> Co-authored-by: Abdelatif Guettouche <[email protected]> Co-authored-by: Vojtěch Bartoška <[email protected]>
aIecxs pushed a commit to aIecxs/arduino-esp32 that referenced this pull request Oct 24, 2024
* Templates and readme * Templates_and_readme
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: DocumentationIssue pertains to Documentation of Arduino ESP32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@VojtechBartoska@pedrominatel@me-no-dev