Argument #2 ($arg) must be passed by reference, value given

[Nightmare]

I'm probably missing something out, but the query is simple and the row is correctly inserted into the db.

I installed it with composer ezsql/ezsql on windows, xampp, php 8.1.4

the, double, error

Warning: ezsql\Database\ez_mysqli::ezsql\Database{closure}(): Argument #2 ($arg) must be passed by reference, value given in C:\xampp\htdocs\vendor\ezsql\ezsql\lib\Database\ez_mysqli.php on line 307

Warning: ezsql\Database\ez_mysqli::ezsql\Database{closure}(): Argument #2 ($arg) must be passed by reference, value given in C:\xampp\htdocs\vendor\ezsql\ezsql\lib\Database\ez_mysqli.php on line 307

use ezsql\Config;
use ezsql\Database\ez_mysqli;

$dsn_path_user	= 'root';
$password	= '';
$database	= 'database';
$other_settings	= '';

$settings = new Config('mysqli', [$dsn_path_user, $password, $database, $other_settings]);

$db = new ez_mysqli($settings);

$db->prepareOn(); // with and without prepareOn

$values = [];
$values['name'] = "test name";
$values['status'] = '1';
$name = 'test name';
$status = 1;

$db->insert('meetings', $values);

i also tried, same error, and new row in the db is inserted.

$db->insert('meetings', ['name' => $name, 'status' => $status]);

or

$db->insert('meetings', ['visitor_name' => "$name", 'status' => "$status"]);

if I do simple query without shortcut it works without errors

$db->query("INSERT INTO meetings (visitor_name, status) VALUES ('$name', 1)");

Thank you

[TheTechsTech]

There are various issues with PHP 8+, and haven't gotten around to addressing.

Seems the warnings is expected starting with PHP 8 to show according to https://www.php.net/manual/en/function.array-reduce.php

You can submit PR to address function array_reduce signature/callback or try pass null instead of ''.

[wninaus]

Hi,
please compare with this issue: elastic/elasticsearch-php#1085
Same behavior for array-reduce and array_walk : https://www.php.net/manual/en/function.array-reduce.php
removing the & in line 294 in lib/Database/ez_mysqli.php solves the problem:

- function ($string, &$arg) use (&$params){
+ function ($string, $arg) use (&$params){

[TheTechsTech]

Seems reasonable, have you tried the patch on PHP 7.4 to see for BC?

[zag2me]

There are various issues with PHP 8+, and haven't gotten around to addressing.

Seems the warnings is expected starting with PHP 8 to show according to https://www.php.net/manual/en/function.array-reduce.php

You can submit PR to address function array_reduce signature/callback or try pass null instead of ''.

Did this error ever get merged? I'm getting loads of these warnings in PHP logs with latest EZSQL and PHP 8.4.

[TheTechsTech]

There was no PR to follow up. And the GitHub Actions CI needs updating to show fix.
Anyway, there are probability other things that need to be address. I'm just not staying up today with PHP nowadays,

I will merge when a PR address current state of things.

[zag2me]

Not sure if this helps, but Visual studio shows a depreciated warning as well on the ezsql code.

I have removed the "&" character on line 294 and it has stopped the huge amount of warnings for now. Seems a bit of a hack though.

I tried to do the PR