Make outputData a std::string#116
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
csegarragonz changed the title randomFloat behaviour for WAMRoutputData a std::stringSign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See faasm/faasm#758
In addition, given that we are updating
libfaasm(requiring a new tag), I also include another change in the signature of random number generation.Apparently, WAMR doesn't like the random devices in
randomFloatto be static. I haven't looked too much into it, but I've seen different behaviour for static variables in WASM files for WAVM and WAMR. This change fixes the issue, but makes batch generation of random numbers considerably slower. If this ever becomes the bottleneck, we can address it separately.