Fix broken OSS tests for python 3.12 from new scikit 1.8.0 release#4643
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Summary: The recent release of scikit-learn to 1.8.0 was picked up in Ax which is causing some tests to break. The only difference in package versions between the newly failing tests and the old passing ones from the nightly run is the scikit-learn library. Pinning the scikit-learn to the most recent package version to resolve. Differential Revision: D88866173
meta-clabot added the CLA Signed 
@mgrange1998 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88866173. |
codecov-commenter commented Dec 10, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #4643 +/- ## ======================================= Coverage 96.54% 96.54% ======================================= Files 561 561 Lines 58480 58480 ======================================= Hits 56462 56462 Misses 2018 2018 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The recent release of scikit-learn to 1.8.0 was picked up in Ax which is causing some tests to break.
The only difference in package versions between the newly failing tests and the old passing ones from the nightly run is the scikit-learn library.
Pinning the scikit-learn to the most recent package version to resolve.
Differential Revision: D88866173