Skip to content

Remove ESLint verification when opting-out#10499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrmckeb merged 2 commits into from
Jun 2, 2021
Merged

Remove ESLint verification when opting-out #10499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1608298
Remove ESLint verification when opting-out
mrmckeb Feb 4, 2021
2a7c931
Use filter instead of if statement
mrmckeb May 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/react-scripts/scripts/utils/verifyPackageTree.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,8 @@ const fs = require('fs');
const semver = require('semver');
const path = require('path');

const isESLintPluginEnabled = process.env.DISABLE_ESLINT_PLUGIN !== 'true'

// We assume that having wrong versions of these
// in the tree will likely break your setup.
// This is a relatively low-effort way to find common issues.
Expand All@@ -21,14 +23,15 @@ function verifyPackageTree(){
// These are packages most likely to break in practice.
// See https://github.com/facebook/create-react-app/issues/1795 for reasons why.
// I have not included Babel here because plugins typically don't import Babel (so it's not affected).
'babel-eslint',
'babel-jest',
'babel-loader',
'eslint',
'jest',
'webpack',
'webpack-dev-server',
];
isESLintPluginEnabled && 'babel-eslint',
isESLintPluginEnabled && 'eslint',
].filter(Boolean);

// Inlined from semver-regex, MIT license.
// Don't want to make this a dependency after ejecting.
const getSemverRegex = () =>
Expand Down