Skip to content

Support marginHeight and marginWidth attributes#2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zpao merged 2 commits into from
Dec 5, 2014
Merged

Support marginHeight and marginWidth attributes #2658

zpao merged 2 commits into from
Dec 5, 2014

Conversation

@ianobermiller
Copy link
Contributor

@ianobermillerianobermiller commented Dec 4, 2014

marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.

@ianobermiller
Support marginHeight and marginWidth attributes
96bd155
marginHeight and marginWidth are used on iframes to set the default body margin inside the iframe.
@syranide
Copy link
Contributor

syranide commented Dec 4, 2014

I wonder if these haven't been superseded by any other property/style? They seem quite exotic (and not present in HTML5) so I can't really find any good informaton. Anyway... it seems they're available as properties even in IE8 and probably shouldn't have MUST_USE_ATTRIBUTE.

@zpao
Copy link
Member

zpao commented Dec 4, 2014

I was trying to find some styles that would supercede them but couldn't. We also already have frameBorder so meh. I'm losing my will to say no to things that aren't (supposedly) supported in HTML5 and we'll support arbitrary properties at some point anyway.

zpao
zpao reviewed Dec 4, 2014
View reviewed changes
src/browser/ui/dom/HTMLDOMPropertyConfig.js Outdated
Copy link
Member

@zpaozpaoDec 4, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If updating these works as properties, let's just do that.

@zpaozpao added this to the 0.12.2 milestone Dec 5, 2014
@zpao
Copy link
Member

zpao commented Dec 5, 2014

👍

zpao added a commit that referenced this pull request Dec 5, 2014
@zpao
Merge pull request#2658from ianobermiller/margin-attrs
5c1589b
Support marginHeight and marginWidth attributes
@zpaozpao merged commit 5c1589b into facebook:masterDec 5, 2014
zpao added a commit to zpao/react that referenced this pull request Dec 18, 2014
@zpao
Merge pull requestfacebook#2658from ianobermiller/margin-attrs
bbe2e88
Support marginHeight and marginWidth attributes
@coveralls
Copy link

coveralls commented Jun 20, 2016

Coverage Status

Changes Unknown when pulling 9d7467e on ianobermiller:margin-attrs into * on facebook:master*.

@aweary
Copy link
Contributor

aweary commented Jun 20, 2016

thanks for the update @coveralls

This was referenced Apr 12, 2023
Open
Open
Open
Open
Open
@MatthelonianxlMatthelonianxl mentioned this pull request Nov 30, 2023
Open
@saurabharchsaurabharch mentioned this pull request Dec 1, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Component: DOM

Projects

None yet

Milestone

0.12.2

Development

Successfully merging this pull request may close these issues.

5 participants

@ianobermiller@syranide@zpao@coveralls@aweary