Updated docs examples/recommendations to use findDOMNode instead of getDOMNode#2802
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ContributorAuthor
jimfb commented Jan 2, 2015
Code change was already merged here: #2646 This new pull request is for the docs update. |
Contributor
waldreiter commented Jan 3, 2015
Maybe add it to the Top-Level API doc as well? |
Member
zpao commented Jan 5, 2015
Yea, let's add the toplevel doc. |
docs/docs/ref-03-component-specs.md Outdated
Collaborator
There was a problem hiding this comment.
Let's kill this note completely.
Member
zpao commented Mar 2, 2015
Alright, lets address the notes and add this to the top level API docs, then we can merge this. |
ContributorAuthor
jimfb commented Mar 6, 2015
@zpao good to go? |
docs/docs/ref-01-top-level-api.md Outdated
Collaborator
There was a problem hiding this comment.
Can you just copy the text from here? http://facebook.github.io/react/docs/component-api.html#getdomnode
Maybe worth adding a note there too saying that React.findDOMNode is preferred.
jimfbforce-pushed the findDOMNode-in-docs branch 2 times, most recently from 036c843 to d157895CompareContributorAuthor
jimfb commented Mar 6, 2015
@spicyj better? |
Collaborator
sophiebits commented Mar 6, 2015
@JSFB shipit |
jimfb added a commit that referenced this pull request Mar 6, 2015
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated docs examples/recommendations to use findDOMNode instead of getDOMNode