Skip to content

Conversation

@duboviy
Copy link
Contributor

No description provided.

@gyermolenko
Copy link
Contributor

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

@duboviy
Copy link
ContributorAuthor

duboviy commented Oct 17, 2019

@duboviy
CI has failed.

Because it goes like this (and it is quite common practice among open-source projs):
travis -> tox testenv -> pytest

Your change fails because tox doesn't have corresponding env yet.
I think you could add env for 38 same as 37.

Thanks a lot @gyermolenko ! I've tried it - works like a charm!

@codecov-io
Copy link

codecov-io commented Oct 17, 2019

Codecov Report

Merging #306 into master will decrease coverage by 0.35%.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #306 +/- ## ========================================== - Coverage 32.82% 32.46% -0.36%  ========================================== Files 42 42 Lines 1496 1534 +38 ========================================== + Hits 491 498 +7 - Misses 1005 1036 +31
Impacted FilesCoverage Δ
patterns/structural/mvc.py0% <0%> (ø)⬆️
...atterns/behavioral/chain_of_responsibility__py2.py0% <0%> (ø)⬆️
patterns/other/blackboard__py3.py0% <0%> (ø)⬆️
patterns/behavioral/catalog.py0% <0%> (ø)⬆️
patterns/behavioral/memento.py0% <0%> (ø)⬆️
patterns/structural/flyweight__py2.py0% <0%> (ø)⬆️
patterns/behavioral/registry__py3.py0% <0%> (ø)⬆️
patterns/behavioral/registry__py2.py0% <0%> (ø)⬆️
patterns/other/blackboard__py2.py0% <0%> (ø)⬆️
...atterns/behavioral/chain_of_responsibility__py3.py0% <0%> (ø)⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e13574b...a916b09. Read the comment docs.

@faiffaif merged commit 24c876d into faif:masterOct 17, 2019
@duboviyduboviy deleted the patch-1 branch October 17, 2019 21:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@duboviy@gyermolenko@codecov-io@faif