Skip to content

Fix allocations crossing 4 GB boundary#64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tobias-loew wants to merge 1 commit into from
Closed

Fix allocations crossing 4 GB boundary #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions MemoryModule.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -597,6 +597,33 @@ HMEMORYMODULE MemoryLoadLibraryEx(const void *data, size_t size,
return NULL;
}
}

#ifdef _WIN64
// Check if the memory-block spans the 4GB border
// ---
// If it does, we have problems, so allocate a new
// block that is fully beyond the 4GB border and
// free the current one. This will be duplicated on
// every subsequent load until some memory allocation
// happens in the memory block covered by this allocation,
// at which point all the memory allocations will be above the
// 4 GB boundary and this conditional will not be hit again
if (code < (LPVOID)0x100000000 && code + alignedImageSize >= (LPVOID)0x100000000)
{
auto old_code = code;
code = (unsigned char *)allocMemory(NULL,
alignedImageSize,
MEM_RESERVE | MEM_COMMIT,
PAGE_READWRITE,
userdata);
freeMemory(old_code, 0, MEM_RELEASE, userdata);
if (code == NULL){
SetLastError(ERROR_OUTOFMEMORY);
return NULL;
}
}
#endif


result = (PMEMORYMODULE)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(MEMORYMODULE));
if (result == NULL){
Expand Down