Skip to content

Conversation

@elsassph
Copy link
Member

Fixes issue #1161

Note: collateral damage is that abbreviation matching is now only enabled for all-uppercase words.

…artMatch. Collateral damage is that abbreviation matching is now only enabled for all-uppercase words.
@Meychi
Copy link
Member

@Neverbirth, @SlavaRa, @wise0704, comments?

@Neverbirth
Copy link
Contributor

I think I completely missed this PR until now... not a part of code I really know. I'd need to try out how the completion feel with the abbreviation change, by looking at the changes it seems to me the issue is already fixed without that behaviour change?

@wise0704
Copy link
Contributor

wise0704 commented Jun 19, 2016

image
Since the method is public, I think you need to add a method with the old signature too...

Something like:

publicstaticintSmartMatch(stringlabel,stringword,intlen){returnSmartMatch(label,word,len,word==word.ToUpperInvariant());}

@elsassph
Copy link
MemberAuthor

It needs unit tests as well, because the weighting was changed a bit randomly.

@Meychi
Copy link
Member

@elsassph: Will you add tests here or should we merge as such?

@elsassph
Copy link
MemberAuthor

We shouldn't merge without tests I believe. I'll try to do it quickly.

@Meychi
Copy link
Member

@elsassph, any progress? :)

@elsassph
Copy link
MemberAuthor

Well... I haven't been able to run tests at all so far :/

@Meychi
Copy link
Member

Any progress?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@elsassph@Meychi@Neverbirth@wise0704