[WIP] Feature/u1141 support latest replication#6
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
However there are still issues as follows. - Some macro definitions conflict between my_global.h and ruby.h - Event handling for receiving binlog data is poor - mysql-replication-listener doesn't support event loop because it stopped using boost::aio event library. With this change, unintentional connection close cannot be detected. Own event-loop implementation would be required. - Previous ruby-binlog code was checking socket object directory, but the socket object of mysql-replication-listener is wrapped with another object.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This change breaks compatibility. Don't merge until ready to release.
This change is for supporting latest mysql-replication-listener which uses mysql client library instead of boost. Since ruby-binlog refers depricated api and internal member variables of replication, some codes needed to be changed.
Todos
my_global.handruby.h