chore(e2e): Pin to react-router 7.10.1 in spa e2e test#18548
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The newly released [React Router 7.11.0](remix-run/react-router#14507) introduced vite preview support(remix-run/react-router#14507). This change has a bug that affects SPA mode (ssr: false). When building in SPA mode, React Router correctly builds the server bundle (build/server/index.js) and then removes it with the message "Removing the server build... due to ssr:false". The new vite preview implementation 7.11.0 doesn't account for this removal and attempts to import the deleted `build/server/index.js` file when starting the preview server, causing the `Cannot find module '/build/server/index.js'` issue.
andreiborza merged commit 97e0be0 into develop 36 checks passed
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly released React Router 7.11.0 introduced vite preview support(remix-run/react-router#14507). This change has a bug that affects SPA mode (
ssr: false).When building in SPA mode, React Router correctly builds the server bundle (
build/server/index.js) and then removes it with the messageRemoving the server build... due to ssr:false.The new vite preview implementation doesn't account for this removal and attempts to import the deleted
build/server/index.jsfile when starting the preview server, causing:Closes#18549 (added automatically)