feat: Officially support 3.14 & run integration tests on 3.14#4974
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
❌ 54 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
sentrivana changed the title ![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Uh oh!
There was an error while loading. Please reload this page.
alexander-alderman-webb approved these changes Oct 22, 2025
Comment on lines +82 to +85
| @pytest.mark.skipif( | ||
| sys.version_info>= (3, 14), | ||
| reason="quart_flask_patch not working on 3.14 (yet?)", | ||
| ) |
Contributor
There was a problem hiding this comment.
What's going on here? Should we make an issue to work on this or will this resolve over time?
ContributorAuthor
There was a problem hiding this comment.
quart_flask_patch is a small library that allows you to use Flask extensions in a Quart app. We don't use it directly, but we have some logic in the Flask integration to detect whether quart_flask_patch is installed and if so, we disable the Flask integration. (Long story short, quart_flask_patch makes a Quart app masquerade as a Flask app in order for Flask extensions to work with it, so our Flask integration tries to auto-enable because "Flask" is installed, and things explode.)
quart_flask_patch last had an update more than a year ago, so not sure if it's even still alive. It's also not used by many folks. If we notice they have a new release at some point, we can adjust, but no need to track it.
sentrivana merged commit 2fadc27 into master 121 checks passed
Uh oh!
There was an error while loading. Please reload this page.
shellmayr pushed a commit that referenced this pull request Oct 30, 2025
### Description Added 3.14 support to package meta and reran toxgen so that it detects we support 3.14 now and updates the test matrix. #### Issues - Closes#4911 - Closes#4910 #### Reminders - Please add tests to validate your changes, and lint your code using `tox -e linters`. - Add GH Issue ID _&_ Linear ID (if applicable) - PR title should use [conventional commit](https://develop.sentry.dev/engineering-practices/commit-messages/#type) style (`feat:`, `fix:`, `ref:`, `meta:`) - For external contributors: [CONTRIBUTING.md](https://github.com/getsentry/sentry-python/blob/master/CONTRIBUTING.md), [Sentry SDK development docs](https://develop.sentry.dev/sdk/), [Discord community](https://discord.gg/Ww9hbqr)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added 3.14 support to package meta and reran toxgen so that it detects we support 3.14 now and updates the test matrix.
Issues
Reminders
tox -e linters.feat:,fix:,ref:,meta:)