- Notifications
You must be signed in to change notification settings - Fork 578
tests(huggingface): Support 1.0.0rc7#4979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Conversation
codecovbot commented Oct 22, 2025 • edited
Loading Uh oh!
There was an error while loading. Please reload this page.
edited
Uh oh!
There was an error while loading. Please reload this page.
❌ 54 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
sentrivana left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could put the repeated logic into a function to dedupe a bit, but also fine the way it is.
cf989a8 into masterUh oh!
There was an error while loading. Please reload this page.
Always use "hf-inference" provider for chat completions, which is the existing behavior of our tests prior to version 1.0.0rc7 of `huggingface_hub`. Closes#4978
Description
The CI fails when you generate
tox.ini, ashuggingface_hubcomplains about a missing API key. See https://github.com/getsentry/sentry-python/actions/runs/18707992581/job/53349699759.Always use
HFInferenceConversational()for chat completions, which is the behavior prior to version 1.0.0rc7 ofhuggingface_hubdue to our mock:sentry-python/tests/integrations/huggingface_hub/test_huggingface_hub.py
Lines 69 to 92 in dcd94ed
We know we have always tested only
HFInferenceConversational()because it's the only provider which does not raise an exception when the API key is missing:https://github.com/huggingface/huggingface_hub/blob/61bc87eb4d774c477ee87c9bf14aa9557ccb4e34/src/huggingface_hub/inference/_providers/hf_inference.py#L31
Issues
Closes#4978
Reminders
tox -e linters.feat:,fix:,ref:,meta:)