Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0pysl0thentr0py commented Nov 25, 2025

Description

The new ERROR and UNSET statuses introduced in #4820 are not supported by relay and caused a regression.

Issues

@sl0thentr0pysl0thentr0py requested a review from a team as a code ownerNovember 25, 2025 15:09
@linear
Copy link

linearbot commented Nov 25, 2025

@codecov
Copy link

codecovbot commented Nov 25, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.97%. Comparing base (7e06f3f) to head (f0be3a9).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
sentry_sdk/integrations/google_genai/__init__.py25.00%3 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #5146 +/- ## ========================================== - Coverage 84.03% 83.97% -0.06%  ========================================== Files 180 180 Lines 18225 18222 -3 Branches 3236 3235 -1 ========================================== - Hits 15315 15302 -13 - Misses 1921 1929 +8 - Partials 989 991 +2 
Files with missing linesCoverage Δ
sentry_sdk/consts.py99.41% <100.00%> (-0.01%)⬇️
sentry_sdk/integrations/anthropic.py82.27% <100.00%> (ø)
...k/integrations/openai_agents/spans/execute_tool.py86.95% <100.00%> (ø)
sentry_sdk/integrations/openai_agents/utils.py90.47% <100.00%> (ø)
sentry_sdk/tracing.py86.22% <100.00%> (-0.03%)⬇️
sentry_sdk/tracing_utils.py87.36% <100.00%> (-0.55%)⬇️
sentry_sdk/integrations/google_genai/__init__.py52.94% <25.00%> (ø)

... and 2 files with indirect coverage changes

@sl0thentr0pysl0thentr0py changed the title Remove unsupported SPANSTATUS.ERRORRemove unsupported SPANSTATUS.(ERROR|UNSET)Nov 25, 2025
@sl0thentr0pysl0thentr0py enabled auto-merge (squash) November 25, 2025 15:45
@sl0thentr0pysl0thentr0py merged commit adab5ac into masterNov 25, 2025
134 of 135 checks passed
@sl0thentr0pysl0thentr0py deleted the neel/fix-error-status branch November 25, 2025 15:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix bad SPANSTATUS.ERROR

3 participants

@sl0thentr0py@alexander-alderman-webb