Skip to content

Conversation

@constantinius
Copy link
Contributor

@constantiniusconstantinius requested a review from a team as a code ownerNovember 26, 2025 14:37
@linear
Copy link

linearbot commented Nov 26, 2025

@constantiniusconstantinius requested a review from a teamNovember 26, 2025 14:37
@codecov
Copy link

codecovbot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.97%. Comparing base (6c6705a) to head (a34668b).
⚠️ Report is 2 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
...y_sdk/integrations/openai_agents/patches/models.py82.35%0 Missing and 3 partials ⚠️
...k/integrations/openai_agents/spans/invoke_agent.py66.66%0 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## master #5157 +/- ## ========================================== - Coverage 83.98% 83.97% -0.02%  ========================================== Files 181 181 Lines 18395 18419 +24 Branches 3275 3281 +6 ========================================== + Hits 15449 15467 +18 - Misses 1937 1938 +1 - Partials 1009 1014 +5 
Files with missing linesCoverage Δ
...dk/integrations/openai_agents/patches/agent_run.py83.33% <100.00%> (+0.52%)⬆️
...y_sdk/integrations/openai_agents/patches/runner.py95.65% <100.00%> (+0.19%)⬆️
..._sdk/integrations/openai_agents/spans/ai_client.py100.00% <100.00%> (ø)
...k/integrations/openai_agents/spans/invoke_agent.py84.61% <66.66%> (-1.88%)⬇️
...y_sdk/integrations/openai_agents/patches/models.py86.84% <82.35%> (-4.07%)⬇️

... and 2 files with indirect coverage changes

model=original_get_model(agent, run_config)
original_get_response=model.get_response

# Wrap _fetch_response if it exists (for OpenAI models) to capture raw response model

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why do we need to capture the raw response model?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only place I found to get the response model. OpenAI Agents does not expose this, we only get the request model, but not the response.

@constantiniusconstantinius merged commit 9c9510d into masterDec 2, 2025
162 of 164 checks passed
@constantiniusconstantinius deleted the constantinius/feat/integrations/openai-agents-usage-response-model branch December 2, 2025 13:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@constantinius@obostjancic@alexander-alderman-webb@sentrivana