Skip to content

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0pysl0thentr0py commented Nov 27, 2025

Description

implement part 1 of https://develop.sentry.dev/sdk/telemetry/traces/#stricttracecontinuation

  • Parse org_id in Dsn constructor
  • Exposeparsed_dsn property on Client and use it in some places to avoid parsing Dsn again
  • New explicit init option org_id that overrides the org_id from the parsed_dsn if provided
  • Add org_id onto populated DSC as head SDK

Issues

@linear
Copy link

linearbot commented Nov 27, 2025

@codecov
Copy link

codecovbot commented Nov 27, 2025

❌ 11 Tests Failed:

Tests completedFailedPassedSkipped
2078811207771789
View the top 3 failed test(s) by shortest run time
tests.test_client::test_transport_option
Stack Traces | 0.154s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.165s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.168s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.172s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.181s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) ^^^^^^^^^^^^^^^^^ E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.2s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) ^^^^^^^^^^^^^^^^^ E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.202s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.202s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.205s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.223s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) ^^^^^^^^^^^^^^^^^ E KeyError: 'org_id'
tests.test_client::test_transport_option
Stack Traces | 0.239s run time
tests/test_client.py:66: in test_transport_option transport = _TestTransport({"dsn": dsn2}) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ sentry_sdk/transport.py:73: in __init__ self.parsed_dsn = Dsn(options["dsn"], options["org_id"]) ^^^^^^^^^^^^^^^^^ E KeyError: 'org_id'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sl0thentr0pysl0thentr0pyforce-pushed the neel/org-id branch 5 times, most recently from c1c414d to d4ca927CompareNovember 27, 2025 14:38
@sl0thentr0pysl0thentr0py marked this pull request as ready for review November 27, 2025 14:46
@sl0thentr0pysl0thentr0py requested a review from a team as a code ownerNovember 27, 2025 14:46
Copy link
Contributor

@sentrivanasentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see one comment

@sl0thentr0pysl0thentr0py merged commit 5fc28a1 into masterNov 27, 2025
155 checks passed
@sl0thentr0pysl0thentr0py deleted the neel/org-id branch November 27, 2025 16:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sl0thentr0py@sentrivana