Skip to content

Conversation

@sentrivana
Copy link
Contributor

@sentrivanasentrivana commented Dec 3, 2025

Fix and simplify our changelog config. We weren't escaping parentheses properly (it needs two backslashes).

  • get rid of all but Changelog: labels
  • match on the word boundary of the first word of the commit message and ignore scope completely since it's not relevant

Issues

Reminders

@sentrivanasentrivana marked this pull request as ready for review December 3, 2025 14:13
@sentrivanasentrivana requested a review from a team as a code ownerDecember 3, 2025 14:13
@sentrivanasentrivana enabled auto-merge (squash) December 3, 2025 14:18
@codecov
Copy link

codecovbot commented Dec 3, 2025

❌ 1 Tests Failed:

Tests completedFailedPassedSkipped
297161297152318
View the top 1 failed test(s) by shortest run time
tests.integrations.sanic.test_sanic::test_transactions[test_config4]
Stack Traces | 0.158s run time
.../integrations/sanic/test_sanic.py:419: in test_transactions with c as client: ^ .tox/py3.12-sanic-v25.3.0/lib/python3.12........./site-packages/sanic_testing/reusable.py:65: in __enter__ self.run() .tox/py3.12-sanic-v25.3.0/lib/python3.12........./site-packages/sanic_testing/reusable.py:77: in run self._server = self._run(self._server_co) ^^^^^^^^^^^^^^^^^^^^^^^^^^ .tox/py3.12-sanic-v25.3.0/lib/python3.12........./site-packages/sanic_testing/reusable.py:198: in _run return self._loop.run_until_complete(coro) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ .../hostedtoolcache/Python/3.12.12....../x64/lib/python3.12/asyncio/base_events.py:691: in run_until_complete return future.result() ^^^^^^^^^^^^^^^ .tox/py3.12-sanic-v25.3.0/lib/python3.12.../sanic/mixins/startup.py:604: in create_server return await serve( .tox/py3.12-sanic-v25.3.0/lib/python3.12.../sanic/server/async_server.py:113: in __await__ self.server = task.result() ^^^^^^^^^^^^^ .../hostedtoolcache/Python/3.12.12....../x64/lib/python3.12/asyncio/base_events.py:1584: in create_server raise OSError(err.errno, msg) from None E OSError: [Errno 98] error while attempting to bind on address ('127.0.0.1', 48706): [errno 98] address already in use

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@sentrivanasentrivana merged commit 05e1bff into masterDec 3, 2025
153 of 155 checks passed
@sentrivanasentrivana deleted the ivana/fix-changelog-config branch December 3, 2025 14:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@sentrivana@alexander-alderman-webb