Skip to content

Conversation

@sl0thentr0py
Copy link
Member

Description

No longer returns None since the last isolation_scope branch will always have one setup by the constructor.

Issues

@sl0thentr0pysl0thentr0py requested a review from a team as a code ownerDecember 10, 2025 19:39
@linear
Copy link

linearbot commented Dec 10, 2025

@sl0thentr0pysl0thentr0pyforce-pushed the neel/prop-context-none branch 2 times, most recently from b92b2ae to 62d97aeCompareDecember 10, 2025 19:42
@codecov
Copy link

codecovbot commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.25%. Comparing base (1ac88a0) to head (516088e).
✅ All tests successful. No failed tests found.

Files with missing linesPatch %Lines
sentry_sdk/scope.py84.61%1 Missing and 1 partial ⚠️
Additional details and impacted files
@@ Coverage Diff @@## neel/more-prop-context-cleanup #5217 +/- ## ================================================================== + Coverage 84.23% 84.25% +0.01%  ================================================================== Files 181 181 Lines 18458 18446 -12 Branches 3282 3276 -6 ================================================================== - Hits 15549 15542 -7 + Misses 1902 1900 -2 + Partials 1007 1004 -3 
Files with missing linesCoverage Δ
sentry_sdk/scope.py89.12% <84.61%> (+1.05%)⬆️

... and 2 files with indirect coverage changes

@sl0thentr0pysl0thentr0pyforce-pushed the neel/more-prop-context-cleanup branch 2 times, most recently from d5b454a to 598e594CompareDecember 11, 2025 13:18
Base automatically changed from neel/more-prop-context-cleanup to masterDecember 11, 2025 13:26
@sl0thentr0pysl0thentr0py enabled auto-merge (squash) December 11, 2025 13:32
@sl0thentr0pysl0thentr0py merged commit a1dab84 into masterDec 11, 2025
169 of 175 checks passed
@sl0thentr0pysl0thentr0py deleted the neel/prop-context-none branch December 11, 2025 13:48
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up PropagationContext None checks

3 participants

@sl0thentr0py@sentrivana