Skip to content

feat: Implement new Propagator.inject for OTLPIntegration#5221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sl0thentr0py merged 2 commits into from
Dec 15, 2025
Merged

feat: Implement new Propagator.inject for OTLPIntegration #5221

sl0thentr0py merged 2 commits into from
Dec 15, 2025
+174 −12

Conversation

@sl0thentr0py
Copy link
Member

@sl0thentr0pysl0thentr0py commented Dec 11, 2025•
edited
Loading

Description

  • bail out of iter_trace_propagation_headers if we have an external_propagation_context
  • handle outgoing headers as best as possible based on just the available SpanContext from otel
  • NOTE for baggage:
    • is correctly passed through in the incoming case
    • but for the head SDK, we cannot populate it in a persistent way across the span tree (no transaction concept)
    • so dynamic sampling with OTLP is out of scope right now

Issues

@sl0thentr0pysl0thentr0pyforce-pushed the neel/otlp-outgoing-propagator branch 3 times, most recently from 7f7d432 to 042f445CompareDecember 12, 2025 15:18
@sl0thentr0pysl0thentr0py marked this pull request as ready for review December 12, 2025 15:18
@sl0thentr0pysl0thentr0py requested a review from a team as a code ownerDecember 12, 2025 15:18
@linear
Copy link

linearbot commented Dec 12, 2025

PY-2010 Apply external_propagation_context in Propagator.inject

cursor[bot]
cursorbot reviewed Dec 12, 2025
View reviewed changes
@sl0thentr0py
Implement new Propagator.inject for OTLPIntegration
e461506
* bail out of `iter_trace_propagation_headers` if we have an `external_propagation_context` * handle outgoing headers as best as possible based on just the available `SpanContext` from otel * NOTE for baggage: * is correctly passed through in the incoming case * but for the head SDK, we cannot populate it in a persistent way across the span tree (no transaction concept) * so dynamic sampling with OTLP is out of scope right now
@sl0thentr0pysl0thentr0pyforce-pushed the neel/otlp-outgoing-propagator branch from 042f445 to e461506CompareDecember 12, 2025 15:30
cursor[bot]
cursorbot reviewed Dec 12, 2025
View reviewed changes
sentrivana
sentrivana approved these changes Dec 15, 2025
View reviewed changes
Copy link
Contributor

@sentrivanasentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sl0thentr0py@sentrivana
Update sentry_sdk/integrations/otlp.py
53b941f
Co-authored-by: Ivana Kellyer <ivana.kellyer@sentry.io>
@sl0thentr0pysl0thentr0py merged commit 1dcf70b into masterDec 15, 2025
153 checks passed
@sl0thentr0pysl0thentr0py deleted the neel/otlp-outgoing-propagator branch December 15, 2025 10:24
@sl0thentr0pysl0thentr0py changed the title Implement new Propagator.inject for OTLPIntegrationfeat Implement new Propagator.inject for OTLPIntegrationDec 16, 2025
@sl0thentr0pysl0thentr0py changed the title feat Implement new Propagator.inject for OTLPIntegrationfeat: Implement new Propagator.inject for OTLPIntegrationDec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

@sentrivanasentrivanasentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apply external_propagation_context in Propagator.inject

3 participants

@sl0thentr0py@sentrivana