Skip to content

fix(clickhouse): Guard against module shadowing#5250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexander-alderman-webb merged 4 commits into from
Jan 9, 2026
Merged

fix(clickhouse): Guard against module shadowing #5250

alexander-alderman-webb merged 4 commits into from
Jan 9, 2026

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webbalexander-alderman-webb commented Dec 17, 2025•
edited
Loading

Description

Use explicit imports to prevent AttributeError when clickhouse_driver is shadowed.

Issues

Follows up on #5140.

Reminders

@alexander-alderman-webbalexander-alderman-webb marked this pull request as draft December 17, 2025 13:42
@alexander-alderman-webbalexander-alderman-webb marked this pull request as ready for review December 18, 2025 08:45
@alexander-alderman-webbalexander-alderman-webb marked this pull request as draft December 18, 2025 09:10
@alexander-alderman-webbalexander-alderman-webb marked this pull request as ready for review December 18, 2025 09:47
sentrivana
sentrivana approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@sentrivanasentrivana left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably quite unlikely that something as specific as clickhouse_driver would be shadowed, but doesn't hurt to be extra safe.

@alexander-alderman-webbalexander-alderman-webb merged commit d781b88 into masterJan 9, 2026
153 checks passed
@alexander-alderman-webbalexander-alderman-webb deleted the webb/clickhouse-nontrivial-import branch January 9, 2026 08:31
This was referenced Jan 9, 2026
Merged
Merged
Open
Merged
Draft
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Open
@sentry-release-botsentry-release-botbot mentioned this pull request Jan 20, 2026
Closed
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentrivanasentrivanasentrivana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexander-alderman-webb@sentrivana