Skip to content

Conversation

@alexander-alderman-webb
Copy link
Contributor

@alexander-alderman-webbalexander-alderman-webb commented Jan 20, 2026

Description

Store only one message from the conversation history on the gen_ai.request.messages attribute.

Remove prior logic that progressively trims away messages. Removes tests that check the existence of conversation histories or prompt messages that are no longer set on the attribute.

Issues

Closes#5335

Reminders

@github-actions
Copy link
Contributor

github-actionsbot commented Jan 20, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

  • feat(anthropic): Set system instruction attribute by alexander-alderman-webb in #5353
  • feat(google-genai): Set system instruction attribute by alexander-alderman-webb in #5354
  • feat(langchain): Set system instruction attribute by alexander-alderman-webb in #5357
  • feat(openai-agents): Set system instruction attribute by alexander-alderman-webb in #5355
  • feat(pydantic-ai): Set system instruction attribute by alexander-alderman-webb in #5356

Bug Fixes 🐛

Ai

  • fix(ai): Keep single content input message by alexander-alderman-webb in #5345
  • fix(ai): Keep single content input message by alexander-alderman-webb in #5345

Internal Changes 🔧

  • ci(release): Fix changelog-preview permissions by BYK in #5368
  • ci: Fix path in AI integration tests by alexander-alderman-webb in #5347

🤖 This preview updates automatically when you update the PR.

@alexander-alderman-webbalexander-alderman-webb marked this pull request as ready for review January 20, 2026 15:04
@alexander-alderman-webbalexander-alderman-webb requested a review from a team as a code ownerJanuary 20, 2026 15:04
Copy link

@cursorcursorbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

scope._gen_ai_original_message_count[span.span_id] =len(messages)

returntruncated_messages
return[truncated_message]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Embeddings input loses all but the last text

Medium Severity

The truncate_and_annotate_messages function is now used for embeddings input in LiteLLM and OpenAI integrations. With the new behavior that always returns only the last item, embeddings with multiple texts (e.g., ["First text", "Second text", "Third text"]) will only capture the last text (["Third text"]). This is data loss - when embedding multiple texts, users expect to see all texts that were embedded, not just the last one. The PR title mentions "message" but embeddings are fundamentally different from chat messages.

Fix in CursorFix in Web

Copy link
ContributorAuthor

@alexander-alderman-webbalexander-alderman-webbJan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will need to address this

@alexander-alderman-webbalexander-alderman-webb marked this pull request as draft January 20, 2026 15:14
@alexander-alderman-webbalexander-alderman-webb changed the base branch from master to webb/openai-ai-prompt-messageJanuary 23, 2026 12:27
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust AI messages trimming logic to only keep the latest message

2 participants

@alexander-alderman-webb