Using HAML#105
Closed
Using HAML #105
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Member
jasonlong commented May 22, 2012
Thanks for the PR and we're sorry for the delay on this end. We have several PRs to get merged and since your's has renamed several files and changed the markup language (which we appreciate - the consistency is needed), we'll need to figure out how best to approach for getting everything integrated. |
MemberAuthor
bry4n commented May 22, 2012
No problem. Yeah, I see several PRs are made for View templates. They can be carefully merged before merging this PR lastly. We can revisit this PR after merges because I think I probably have to update this PR. |
MemberAuthor
bry4n commented Aug 13, 2012
Closing this PR for now and I'll create new PR with new changes |
yosadchuk pushed a commit to yosadchuk/git-scm.com that referenced this pull request Aug 29, 2014
[ru] little fix so makepdfs work now
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gitscm-next had a mix of ERB and HAML files. I converted all ERB files into HAML files via
html2hamltool with minor tweaks to ensure that the layout page isn't broken.I am unsure about one particular file
app/views/shared/_related.html.haml. It contains "Related Stackoverflow Questions". I can't find any pages that depends it, then renamed it to_related.html.haml.bak.Let me know if you need that file back or delete it.