Add a few details about optimizing writes to unchanged files#293
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
In regards to the story about optimizing writes to unchanged files: 1) The text noted that en/rename-directory-detection-reboot would be merged to next soon (that's what the last cooking email said), but it has since been merged to next.. 2) It's worth noting that Junio found a bug with Linus' proposed "stupid brute force" patch (namely that if a file involved in a rename has dirty changes before a merge, those dirty changes could be overwritten without warning to the user). 3) Finally, since there is a specific commit message that explains the history of the can-we-skip-worktree-updates check and what fix was used, link to it so the curious can dig more (without having to read all the patches about directory rename detection).
ContributorAuthor
newren commented May 14, 2018
I tried to match style and rewrite as little as possible while adding a few extra pointers. Feel free to take whichever pieces make sense to you and modify as you see fit. |
Collaborator
chriscool commented May 14, 2018
Your changes looks great! Thanks! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In regards to the story about optimizing writes to unchanged files:
merged to next soon (that's what the last cooking email said), but it
has since been merged to next..
brute force" patch (namely that if a file involved in a rename has
dirty changes before a merge, those dirty changes could be overwritten
without warning to the user).
history of the can-we-skip-worktree-updates check and what fix was
used, link to it so the curious can dig more (without having to read
all the patches about directory rename detection).