Soc-2022-Ideas: Sparse Index Integrations#550
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
sivaraam reviewed Feb 9, 2022
Member
sivaraam left a comment
sivaraam left a comment There was a problem hiding this comment.
Thanks @derrickstolee ! The idea seems well written. It looks fine for the most part. Just a few minor comments and I think we can merge this one.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Derrick Stolee <[email protected]>
derrickstoleeforce-pushed the gsoc-sparse-index branch from 7f0a7e4 to ca84c79Compare
Collaborator
chriscool commented Feb 9, 2022
Yeah, I like it! And it LGTM! Thanks @derrickstolee! Thanks also @sivaraam for a good review and good suggestions! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on the mailing list, here is an idea for a student project.
cc: @vdye, @sivaraam