rn-105: minor copy edit#674
Merged
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
chriscool commented Nov 30, 2023
Thanks @stepnem ! I don't have much time today to take a look, but maybe @mjaix as he usually works on small fixes will be able to take a look. Otherwise I will take a look tomorrow. About the Draft for last month, you are right, I made a mistake. Instead of putting a lot of people in Cc: I put them in the To: field and forgot to add the mailing list email address to the To:. So the mailing list didn't receive it as usual. Sorry about this. This shouldn't happen again, but if you want I can always put you in Cc:. You would also be welcome to join the team, so that you could modify the master branch directly. |
ContributorAuthor
stepnem commented Nov 30, 2023 via email
This shouldn't happen again, but if you want I can always put you in Cc:. I think that would be helpful, thank you. You would also be welcome to join the team, so that you could modify the master branch directly. I don't see anything that should prevent me from continuing to review the notes in a way similar to the few recent issues in the near future; OTOH I don't see myself contributing much more than that (and I'd like to thank you all for the great work you are doing here; to mention one point in particular, I really appreciate that you not only collect and comment on all the various links, but also go the extra mile of adding references to previous mentions of related topics), so the external contribution seems to me to better reflect my role; that said, I tend to keep the edits rather conservative and hopefully wouldn't present any danger to the project, so if you feel having me commit to master would be more convenient for you, I'd be OK with that, too. |
mjaix approved these changes Nov 30, 2023
Contributor
mjaix left a comment
mjaix left a comment There was a problem hiding this comment.
IMHO just an excellent contribution.
Contributor
mjaix commented Nov 30, 2023 via email
***@***.***, I just merged your contribution - IMHO just excellent. Thanks a lot. @chriscool: Is it OK for you if I proceed with looking for small fixes this evening latest before 22:00? |
Contributor
mjaix commented Dec 1, 2023 via email
** sent again from the appropriate email address ** Great - I also would have preferred to use Štěpán's full name, but failed to look it up :-(. |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(BTW, most likely I would have reviewed rn104, too, but
apparently you didn't send the usual Draft mail last month.)