SoC-2024: improve positioning of logo in small screens#694
Uh oh!
There was an error while loading. Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We could align the image to right only on bigger screens as it looks good only when the space on the left is enough for some decent amount of content to be shown. On smaller screens, we could just place the image on its one chunk of space (default behaviour when including images in Markdown) and let the content follow it. Tweak the styles to accordingly for this.
Collaborator
chriscool commented Feb 26, 2024
Looks great! Thanks @sivaraam ! |
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We could align the image to right only on bigger screens as it looks good only when the space on the left is enough for some decent amount of content to be shown. On smaller screens, we could just place the image on its one chunk of space (default behaviour when including images in Markdown) and let the content follow it.
Tweak the styles to accordingly for this.
Screen shot of page on big screen
Screen shot of page on small screen