Skip to content

update pyproject.toml and dependencies#17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andre15silva merged 3 commits into from
Mar 1, 2024
Merged

update pyproject.toml and dependencies #17

andre15silva merged 3 commits into from
Mar 1, 2024

Conversation

@andre15silva
Copy link
Member

@andre15silvaandre15silva commented Mar 1, 2024

Closes#16

@andre15silvaandre15silva mentioned this pull request Mar 1, 2024
Closed
@andre15silva
Copy link
MemberAuthor

andre15silva commented Mar 1, 2024•
edited
Loading

The package-mode option is only available in Poetry>=1.8, we need a workaround to be able to support earlier versions.

@Nfsaavedra
Copy link
Contributor

Nfsaavedra commented Mar 1, 2024•
edited
Loading

The package-mode option is only available in Poetry>=3.8, we need a workaround to be able to support earlier versions.

I'm confused about this comment, the last version of poetry is 1.8, do you mean Python? @andre15silva

@andre15silva
Copy link
MemberAuthor

andre15silva commented Mar 1, 2024

The package-mode option is only available in Poetry>=1.8, we need a workaround to be able to support earlier versions.

I'm confused about this comment, the last version of poetry is 1.8, do you mean Python? @andre15silva

I meant 1.8 yes, croaker uses 1.7 for example and it did not work there.

Nfsaavedra
Nfsaavedra approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@NfsaavedraNfsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andre15silvaandre15silva merged commit ff352a7 into mainMar 1, 2024
@NfsaavedraNfsaavedra deleted the update-pyproject branch March 12, 2024 14:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NfsaavedraNfsaavedraNfsaavedra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Possibly incorrect value of the name property inside pyproject.toml file

3 participants

@andre15silva@Nfsaavedra