Skip to content

Conversation

@dseomn
Copy link
Contributor

https://www.netmeister.org/blog/passing-passwords.html has a decent overview of the security issues with that.

Since this is interactive, getting curl to prompt for the password is probably the easiest alternative. From
https://curl.se/docs/manpage.html#-u

If you simply specify the username, curl prompts for a password.

I don't have an easy way to test the actual command in this doc, but the flag does seem to behave as documented at least:

$ curl --user [email protected] https://google.com Enter host password for user '[email protected]' 

Fixesgitgitgadget/gitgitgadget#1843

https://www.netmeister.org/blog/passing-passwords.html has a decent overview of the security issues with that. Since this is interactive, getting curl to prompt for the password is probably the easiest alternative. From https://curl.se/docs/manpage.html#-u > If you simply specify the username, curl prompts for a password. I don't have an easy way to test the actual command in this doc, but the flag does seem to behave as documented at least: ``` $ curl --user [email protected]https://google.com Enter host password for user '[email protected]' ``` Fixesgitgitgadget/gitgitgadget#1843
@dseomn
Copy link
ContributorAuthor

Is this a bug in the workflow, or am I supposed to do something? I do have "allow edits by maintainers" checked.

Run git config user.name "dseomn" && [cmdline-no-secrets 10adce5] Convert Markdown to HTML 1 file changed, 1 insertion(+), 1 deletion(-) remote: Permission to dseomn/gitgitgadget.github.io.git denied to github-actions[bot]. fatal: unable to access 'https://github.com/dseomn/gitgitgadget.github.io/': The requested URL returned error: 403 Error: Process completed with exit code 128. 

@dscho
Copy link
Member

dscho commented Mar 5, 2025

Is this a bug in the workflow

This is something I wasn't sure whether it could work, see "Verify that the PR workflow succeeds to push updates even for PRs that originated from a fork" in #21 (comment).

@dscho
Copy link
Member

dscho commented Mar 5, 2025

Let me see what I can do about this.

dschoand others added 2 commits March 6, 2025 01:48
When the HTML page(s) are not up to date, the PR build re-generates them, commits the result and wants to push it to the branch. However, this only works if the PR branch and the target branch are in the same repository. Otherwise the workflow run's `GITHUB_TOKEN` lacks write permission, even if the PR author gave permission to the maintainers to push to that branch. Let's fall back to doing the next best thing and publish a Git bundle, and provide instructions how to fetch from them and update the PR with those changes. Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Mar 6, 2025

There. 3rd times 3rd time is a charm:

image

For the record: I changed the PR build so that it no longer tries to push to the branch (unless the PR originates from the same repository) but instead publishes a Git bundle and describes how to pull from said bundle and then update the PR, which is what I did and therefore the PR build passed successfully.

Thank you @dseomn for your patience and for the contribution!

@dschodscho merged commit 895f851 into gitgitgadget:mainMar 6, 2025
1 check passed
@dseomndseomn deleted the cmdline-no-secrets branch March 6, 2025 01:11
@dschodscho mentioned this pull request Mar 8, 2025
dscho added a commit that referenced this pull request Mar 8, 2025
Rather than trying to continue running something home-grown, let's switch to a proper static site generator. This partially addresses some concerns I [raised after integrating the wiki pages](#21 (comment)) and the problems we ran into when [the workflow to update the HTML pages failed in a PR by a contributor](#22 (comment)): While it still does not offer convenient before/after views, it at least allows to preview the changes in a fork, just like this here PR can be previewed at https://dscho.github.io/gitgitgadget.github.io/ So why even bother with a powerful site generator like Hugo for something as small as GitGitGadget's home page? Well, here are a couple of reasons: - As you can see https://dscho.github.io/gitgitgadget.github.io/architecture, it re-adds the syntax highlighting in code blocks that were lost in the transition away from the wiki. - It will make auto-generating a navigation bar (or a central index page) much easier. - It will make it easier to maintain a unified look-and-feel, e.g. when adding something like an "Edit on GitHub" button. - It should make it somewhat easier to make the site [responsive](#19) because of a much more standard way to build the site. - The migration of the wiki pages was meant as a blueprint I could follow in Git for Windows, where I want to stop wasting my time battling spam and vandalism, and any subsequent work over here that can help with that can increase the synergy between both projects.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ReplyToThis could offer more secure advice

2 participants

@dseomn@dscho