Skip to content

Conversation

@bdrodes
Copy link
Contributor

  • Added MaD sinks for URLs in the azure SDK, labeled as 'ssrf'
  • Updated HTTP request clients to use 'ssrf' MaD

@bdrodesbdrodes requested a review from a team as a code ownerSeptember 30, 2025 17:58
CopilotAI review requested due to automatic review settings September 30, 2025 17:58
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Server-Side Request Forgery (SSRF) modeling for the Azure Python SDK by introducing MaD (Models as Data) sinks and updating HTTP request clients to recognize SSRF vulnerabilities. This enables CodeQL to detect when user input can control URLs passed to Azure SDK methods.

  • Added SSRF sink modeling framework for MaD-based HTTP requests
  • Created comprehensive Azure SDK models for KeyVault and Storage services
  • Added test coverage for Azure client SSRF scenarios

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
python/ql/lib/semmle/python/frameworks/SSRFSink.qllNew framework for handling SSRF sinks through MaD models
python/ql/lib/semmle/python/frameworks/Azure.Storage.model.ymlMaD definitions for Azure Storage SDK SSRF sinks
python/ql/lib/semmle/python/frameworks/Azure.Keyvault.model.ymlMaD definitions for Azure KeyVault SDK SSRF sinks
python/ql/lib/semmle/python/Frameworks.qllImport statement for new SSRFSink framework
python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/test_azure_client.pyTest cases for Azure SDK SSRF detection
python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/PartialServerSideRequestForgery.expectedExpected results for partial SSRF tests
python/ql/test/query-tests/Security/CWE-918-ServerSideRequestForgery/FullServerSideRequestForgery.expectedExpected results for full SSRF tests
python/ql/lib/change-notes/released/2025-09-30-azure_ssrf_modelsRelease notes for the changes

@MathiasVPMathiasVP requested a review from tausbnOctober 14, 2025 15:26
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@bdrodes