Skip to content

Conversation

@walkerk1980
Copy link
Contributor

@GrantBirki
Copy link
Contributor

GrantBirki commented Oct 11, 2024

Hey @walkerk1980 thank you for this PR! The file you are trying to edit (dist/index.js), is actually a file that gets auto generated when running npm run all after making changes to the source files. The actual file you will need to edit is this one:

if(skip_completing==='true'){

After editing this file please ensure to run npm run test and npm run all to ensure everything works as expected, and commit the auto-generated file changes. Thanks! 🙇

@walkerk1980
Copy link
ContributorAuthor

walkerk1980 commented Oct 14, 2024

Hey @walkerk1980 thank you for this PR! The file you are trying to edit (dist/index.js), is actually a file that gets auto generated when running npm run all after making changes to the source files. The actual file you will need to edit is this one:

if(skip_completing==='true'){

After editing this file please ensure to run npm run test and npm run all to ensure everything works as expected, and commit the auto-generated file changes. Thanks! 🙇

Sorry, I didn't bother to read CONTRIBUTING.md before. 🤦

Force pushed a new commit.

@GrantBirkiGrantBirki added the bug Something isn't working label Oct 14, 2024
@GrantBirkiGrantBirki merged commit ca43e96 into github:mainOct 14, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugSomething isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@walkerk1980@GrantBirki